Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with desktops using the --use-display flag being shifted 2.25 px down #338

Merged
merged 3 commits into from
Dec 4, 2024

Conversation

CorbinWunderlich
Copy link
Contributor

Had to create this new one because github wouldn't let me reopen #337 . Anyway, this solution is a little bit hardcoded, but it should be fine (most likely).

@totaam
Copy link
Collaborator

totaam commented Dec 3, 2024

How did you come up with 2.25? by the eye?
Isn't this likely to change based on hidpi, platform, etc?

What is the difference in resolution between a new session and a --use-display one?

I would prefer fixing the underlying bug (whatever that may be) rather than hard-coding values I don't understand.

@CorbinWunderlich
Copy link
Contributor Author

CorbinWunderlich commented Dec 3, 2024 via email

@CorbinWunderlich
Copy link
Contributor Author

How did you come up with 2.25? by the eye? Isn't this likely to change based on hidpi, platform, etc?

What is the difference in resolution between a new session and a --use-display one?

I would prefer fixing the underlying bug (whatever that may be) rather than hard-coding values I don't understand.

This is probably better.

@CorbinWunderlich
Copy link
Contributor Author

Oh, I left some stuff in. One second, I will get rid of those.

@CorbinWunderlich
Copy link
Contributor Author

CorbinWunderlich commented Dec 3, 2024

@totaam There, that should do it.

@CorbinWunderlich
Copy link
Contributor Author

Just added some changes that would edit some icons (delete unused ones and update the 4 year old Material Icons). Note that they have been updated to 2 year old Material Icons, as the ttfs that they provide are deprecated

@totaam
Copy link
Collaborator

totaam commented Dec 4, 2024

Can you keep the icon changes separate?
Also, I don't see what replaces the speaker and clipboard icons.

@CorbinWunderlich
Copy link
Contributor Author

CorbinWunderlich commented Dec 4, 2024 via email

@totaam
Copy link
Collaborator

totaam commented Dec 4, 2024

Ah, silly me!
Makes sense.

@totaam totaam merged commit 6f0f339 into Xpra-org:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants