Add gaming cursor mode (pointer lock) and a small bugfix #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
totaam
reviewed
Dec 2, 2024
CorbinWunderlich
force-pushed
the
master
branch
from
87bb0dc to
cca3518
Compare
This makes first-person gaming over Xpra finally usable.
CorbinWunderlich
force-pushed
the
master
branch
from
cca3518 to
7287ce7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointer lock makes gaming over Xpra finally usable and actually works pretty well. When cursor lock is turned on, it automatically locks you to the focused window (which counts the desktop in desktop mode), and when you exit with with the
esckey, it pauses, and waits for you to click on a new window to lock on. The paused mode (and cursor lock) is disabled by default and can be disabled through the float menu, with some colors to indicate.The small bugfix is just using my new css classes to color the keyboard in as well, as the previous approach to coloring it wasn't working as jQuery cannot change css
:beforeattributes.