Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing/jenkins integration #59

Merged
merged 79 commits into from
Feb 21, 2024
Merged

Testing/jenkins integration #59

merged 79 commits into from
Feb 21, 2024

Conversation

fionnodonohoe-xlnx
Copy link
Contributor

@fionnodonohoe-xlnx fionnodonohoe-xlnx commented May 25, 2023 •
edited
Loading

Adding a CI pipeline for everyday development and for release testing cycles.

This commit may need to be reverted: 00c3c4f

I was expecting license issues when building bitstreams, so I decoupled the get-finn.sh script in order to do some license fudging in my Jenkins pipeline. This doesn't seem necessary - still running the last test to verify this however.

fionnodonohoe-xlnx and others added 27 commits April 5, 2023 21:24
@fionnodonohoe-xlnx
[test] adding basic Jenkinsfile
557cd1d 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
[testing] add pytest testing module for testing notebooks on boards
aabf800 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
[testing] add script that downloads necessary testing files for finn-…
f146d0b 
…examples notebooks - intended to be run on the target host

Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
Merge branch 'testing/notebook_automation' into testing/jenkins-integ…
2a3d9ba 
…ration
@fionnodonohoe-xlnx
Remove get-finn script execution for decoupling
00c3c4f
@fionnodonohoe-xlnx
build-all.sh was not creating all necessary zipfiles as it was in the…
056af4a 
… wrong directory
@fionnodonohoe-xlnx
Remove commented out lines
d4105a1
@fionnodonohoe-xlnx
[testing] make downloading board files optional
b35e68a 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
[testing] update relative path to the data & bitfile directories
63f1deb 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
Try using the radioml_w4a4_small_tidy bitfile that already exists for…
e99dab0 
… the ZCU104
@fionnodonohoe-xlnx
Revert "Try using the radioml_w4a4_small_tidy bitfile that already ex…
52d4667 
…ists for the ZCU104"

This reverts commit e99dab0.

Reverting in favour of using the fix from pull request #58
@fionnodonohoe-xlnx
Select mobilenet for testing
69b83ba
@fionnodonohoe-xlnx
add pytest markers to prevent warnings when running tests
9dab943 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
add pipeline for 3/4 boards - zcu104 missing
c3aeddc 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
mark binarycop as xfail - camera is expected but not connected to the…
4d397b0 
… Pynq device

Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
add the ZCU104 tests; triggered by a buildParameter
fa4a6a3 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
tidy up post actions
c7d1cab 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
add release build stage and build parameter; check build parameters i…
7fe463f 
…n existing stages

Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
tidy up formatting & remove env vars already set in DSL job file
f8f82ab 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
Set all function names to camel case for consistency
7e93bc4 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
gather repeated code into a function: getBoardFiles; also add in alve…
1dc1f12 
…o kludge in order to download correct bitstreams

Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
adjust U250 platform JSON key to allow for simpler use
2109058 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
remove unused prints and comments; adjust tabbing to improve flow con…
d14755e 
…trol

Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
move download-test-files.py to ci directory as it's only used for con…
b0a81b1 
…tinuous integration

Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
Move conda environment and move path to an environment variable
228878c 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
add a prepending backslash to a backslash so that groovy can read nec…
61b3d89 
…essary backslash

Signed-off-by: Fionn O'Donohoe <[email protected]>
@fionnodonohoe-xlnx
the fancy folder renaming method did not work during a Jenkins run
9015ecb 
Signed-off-by: Fionn O'Donohoe <[email protected]>
@jmonks-amd jmonks-amd force-pushed the testing/jenkins-integration branch from 9cae1a5 to 30b8f0d Compare October 23, 2023 10:03
jmonks-amd
jmonks-amd requested changes Oct 26, 2023
View reviewed changes
ci/Jenkinsfile Show resolved Hide resolved
ci/Jenkinsfile Outdated Show resolved Hide resolved
ci/Jenkinsfile Outdated Show resolved Hide resolved
ci/Jenkinsfile Show resolved Hide resolved
ci/Jenkinsfile Outdated Show resolved Hide resolved
ci/Jenkinsfile Outdated Show resolved Hide resolved
@jmonks-amd jmonks-amd force-pushed the testing/jenkins-integration branch from 159876a to a548520 Compare November 1, 2023 09:25
johnnoel and others added 4 commits November 3, 2023 16:05
Revert "[CI] Temporarily disable alveo based tests"
8a58fd2 
This reverts commit a548520.
[Driver] Workaround for pynq on alveo bug
c9814dd 
Pynq on alveo uses tinynumpy under the hood which has a bug when converting between tinynumpy.ndarray and numpy.ndarray. Workaround is to first convert to list and then to numpy.ndarray.
@auphelia
Update finn commit
ac69a57
[Test] Update models.py to handle alveo pynq naming
9ff8df0
@jmonks-amd jmonks-amd force-pushed the testing/jenkins-integration branch from 9136a52 to 9ff8df0 Compare November 23, 2023 09:39
@jmonks-amd jmonks-amd force-pushed the testing/jenkins-integration branch from df92fff to 1487dac Compare December 4, 2023 10:03
@jmonks-amd jmonks-amd force-pushed the testing/jenkins-integration branch from ce1a289 to 0380b59 Compare February 21, 2024 15:07
@jmonks-amd jmonks-amd force-pushed the testing/jenkins-integration branch from 0380b59 to 9f935ea Compare February 21, 2024 15:07
@jmonks-amd jmonks-amd merged commit 781559f into dev Feb 21, 2024
1 check passed
@jmonks-amd jmonks-amd deleted the testing/jenkins-integration branch February 21, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmonks-amd jmonks-amd jmonks-amd approved these changes

@mmrahorovic mmrahorovic Awaiting requested review from mmrahorovic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fionnodonohoe-xlnx @jmonks-amd @mmrahorovic @auphelia