Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (llm): benchmark for llm entrypoint #1166

Open
wants to merge 12 commits into
base: dev
Choose a base branch
from

Conversation

pablomlago
Copy link
Collaborator

@pablomlago pablomlago commented Jan 20, 2025

Reason for this PR

Enable running the LLM entrypoint in a grid-seach manner for a subset of argument combinations specified through a YAML file. Moreover, workloads can be divided between different process, each of them running the LLM entrypoint in a mutually exclusive set of GPUs.

Changes Made in this PR

Refactored the argument parsing logic of the LLM entrypoint, moving it to a separate file, thus enabling to leverage the LLM parser before doing any import to torch, which would cause the CUDA devices to be initialized. By doing so, the cuda initialization takes into account the different values for CUDA_VISIBLE_DEVICES that each process sets. Also, results from the LLM entrypoint are now grouped into a single dictionary to facilitate retrieving them.

Testing Summary

Ran the benchmark script locally.

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@pablomlago pablomlago force-pushed the feat-llm-benchmark-yaml branch from f7879ea to 799920f Compare February 6, 2025 14:09
@pablomlago pablomlago marked this pull request as ready for review February 6, 2025 14:09
@pablomlago pablomlago force-pushed the feat-llm-benchmark-yaml branch from 55861af to e0d638e Compare February 7, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant