Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eval harness #1131

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Eval harness #1131

merged 3 commits into from
Dec 20, 2024

Conversation

Giuseppe5
Copy link
Collaborator

Reason for this PR

Changes Made in this PR

Testing Summary

Risk Highlight

  • This PR includes code from another work (please detail).
  • This PR contains API-breaking changes.
  • This PR depends on work in another PR (please provide links/details).
  • This PR introduces new dependencies (please detail).
  • There are coverage gaps not covered by tests.
  • Documentation updates required in subsequent PR.

Checklist

  • Code comments added to any hard-to-understand areas, if applicable.
  • Changes generate no new warnings.
  • Updated any relevant tests, if applicable.
  • No conflicts with destination dev branch.
  • I reviewed my own code changes.
  • Initial CI/CD passing.
  • 1+ reviews given, and any review issues addressed and approved.
  • Post-review full CI/CD passing.

@Giuseppe5 Giuseppe5 force-pushed the eval_harness branch 2 times, most recently from 01350d7 to 89609d8 Compare December 18, 2024 16:25
@Giuseppe5 Giuseppe5 requested a review from i-colbert December 18, 2024 16:26
nickfraser
nickfraser approved these changes Dec 20, 2024
View reviewed changes
Copy link
Collaborator

@nickfraser nickfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but with comments ;)

src/brevitas_examples/llm/main.py Outdated Show resolved Hide resolved
src/brevitas_examples/llm/main.py Outdated Show resolved Hide resolved
@nickfraser
Copy link
Collaborator

Regenerate README and config/default/yml.

nickfraser
nickfraser reviewed Dec 20, 2024
View reviewed changes
src/brevitas_examples/llm/main.py
model=wrapped_model,
model_args=None,
tasks=list(args.zero_shot_tasks),
device='cuda:0',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be auto for accelerate?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/EleutherAI/lm-evaluation-harness/blob/6ccd520f3fb2b5d74c6f14c05f9d189521424719/lm_eval/evaluator.py#L93

Looks like it only support torch devices. Even with accelerate, the execution device is always GPU 0, and that's where the data should go. Accelerate will take care of everything else under the hood.

@Giuseppe5 Giuseppe5 merged commit 39ce837 into Xilinx:dev Dec 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickfraser nickfraser nickfraser approved these changes

@i-colbert i-colbert Awaiting requested review from i-colbert

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Giuseppe5 @nickfraser