-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decoupled PerChannel/PerTensor quantization #1025
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Single question about test organisation (specifically, fixtures), otherwise LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a code style question, any reason why we don't use the standard pytest
way of sharing fixtures across multiple files (i.e., conftest.py
)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a lot of duplication for various reasons and in general tests would need to be restructured a bit.
All this to say that I wouldn't be sure at his point of the cleanest way to do it myself, but if you have a suggestion, all ears.
To have a decouple per channel pre-scale, and per tensor post scale:
It currently works for all quantizers that inherit from
WeightNormPerChannelFloatDecoupled
It can be extended to other decoupled quantization quantizers if needed