Support AIE columns with multiple controllers #8688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxzhen
approved these changes
Jan 11, 2025
xuhz
reviewed
Jan 11, 2025
When extracting MicroBlaze control code from ELF for a multi-column partition, account for each column having multiple controllers and that a partition may not use all of these. ELF sections identify which column controllers are used. Currently this done through an ELF section naming convention. Before this change, each column had exactly one controller and it was assumed that either the lead controller in a partition was used alone or with all remaining controllers in subsequent columns. With this PR, support is added for multiple controllers in each column and for only a subset of these controllers being used. The ERT packet payload interpretation for ert_dpu_data is changed to indicate which column processor the data is associated with. Signed-off-by: Soren Soe <[email protected]>
stsoe
force-pushed
the
uc_ctrlcode_aie4
branch
from
d1caa98 to
127f9d8
Compare
Signed-off-by: Soren Soe <[email protected]>
xuhz
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
When extracting MicroBlaze control code from ELF for a multi-column partition, account for each column having multiple controllers and that a partition may not use all of these.
How problem was solved, alternative solutions (if any) and why they were rejected
ELF sections identify which column controllers are used. Currently this done through an ELF section naming convention.
Before this change, each column had exactly one controller and it was assumed that either the lead controller in a partition was used alone or with all remaining controllers in subsequent columns. With this PR, support is added for multiple controllers in each column and for only a subset of these controllers being used.
The ERT packet payload interpretation for ert_dpu_data is changed to indicate which column processor the data is associated with.