VITIS-13807 : Use opencl icd dispatcher instead of ocl icd for embedded flows #8686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsoe
approved these changes
Jan 9, 2025
| #else | ||
| // All x86 linux distros doesn't have opencl icd dispatcher | ||
| // support so using ocl icd dispatcher for x86 flows. | ||
| # include "ocl_icd.h" |
There was a problem hiding this comment.
Can we indicate system header with angle brackets as it used to be?
Suggested change
| # include "ocl_icd.h" | |
| # include <ocl_icd.h> |
There was a problem hiding this comment.
sure Soren
added 2 commits
January 10, 2025 08:45
Signed-off-by: rbramand <[email protected]>
Signed-off-by: rbramand <[email protected]>
rbramand-xilinx
force-pushed
the
icd_loader
branch
from
b5c8e54 to
89076de
Compare
chvamshi-xilinx
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Moved to Opencl icd dispatcher from ocl icd dispatcher for embedded platforms as yocto is deprecating the use of ocl icd flows.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Yocto team filed story VITIS-13807
How problem was solved, alternative solutions (if any) and why they were rejected
The best fix is to move all the flows to opencl icd way but the problem is all the linux distributions (RHEL, CentOS) doesn't ship packages to support opencl icd flow, so only made changes to embedded flow.
Also this change is made under temporary flag OPENCL_ICD_LOADER so that XRT builds doesn't break till changes in XRT recipe related to opencl icd loader in yocto/petalinux get into TA. This flag will be removed soon.
Risks (if any) associated the changes in the commit
Low as both ocl icd and opencl icd are almost similar and the only change is structure cl_icd_dispatch members differ a little which we already dont use (we already fill zeros as those APIs are not supported in our flow).
What has been tested and how, request additional testing if necessary
Tested Embedded flows build and OpenCL test cases.
Tested x86 build.
Documentation impact (if any)
Most likely no as user doesn't need to understand about the dispatcher we use.