XDP: Initial Support for Trace and Profile on VE2 #8670
Conversation
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
Signed-off-by: parthash0804 <[email protected]>
| @@ -0,0 +1,36 @@ | |||
| /** | |||
| * Copyright (C) 2020 Xilinx, Inc | |||
There was a problem hiding this comment.
Update Copyright messages in all of the new/updated files
| * under the License. | ||
| */ | ||
|
|
||
| #ifndef XDP_PROFILE_AIE_TRACE_LOGGER_H |
There was a problem hiding this comment.
"XDP_PROFILE_AIE_TRACE_LOGGER_H" macro is already used in xdp/profile/device/aie_trace/aie_trace_logger.h . Although these two files are not expected to be compiled in a single flow, it is better to use unique name for the macro guard to avoid unexpected behavior, if there is a change in flow in future.
Please rename the macro guard to XDP_PROFILE_AIE_TRACE_VE2_LOGGER_H
| * XRT_X86_BUILD is set only for x86 builds | ||
| * Only compile this on edge+versal build | ||
| */ | ||
| #if defined (XRT_ENABLE_AIE) && ! defined (XRT_X86_BUILD) && ! defined (XDP_CLIENT_BUILD) |
There was a problem hiding this comment.
Are these macro guards required for VE2 flow? The current cpp file is compiled only under XDP_VE2_BUILD_CMAKE. Can XRT_X86_BUILD, XDP_CLIENT_BUILD be ever set for VE2? Also, can AIE be disabled for VE2?
| * XRT_X86_BUILD is set only for x86 builds | ||
| * Only compile this on edge+versal build | ||
| */ | ||
| #if defined (XRT_ENABLE_AIE) && ! defined (XRT_X86_BUILD) |
There was a problem hiding this comment.
Are these macro checks required for VE2?
|
|
||
| #include "xdp/profile/device/tracedefs.h" | ||
|
|
||
| #if defined (XRT_ENABLE_AIE) && ! defined (XRT_X86_BUILD) |
| @@ -7,7 +7,9 @@ | |||
| # on both Edge and x86 platforms that support AIE. | |||
There was a problem hiding this comment.
Update comment to include VE2 and also Client.
|
@chvamshi-xilinx As Jason is OOO, please review this PR. |
| @@ -7,7 +7,11 @@ | |||
| # Edge-Versal systems, but not Edge-aarch64. It also has a dependency | |||
| # on the hardware shim | |||
| # ==================================================================== | |||
There was a problem hiding this comment.
Update comment to include VE2 and also Client.
|
@parthash0804 Please use VE2 in your PR and branch. |
parthash0804
changed the title
|
@jvillarre / @IshitaGhosh / @pgschuey I have renamed my branch name and pushed the changes but the PR doesn't points to the updated branch. So I am creating a new PR and closing this PR. cc: @chvamshi-xilinx |
Problem solved by the commit
Added support for Trace and profile plugins for VE2 device.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
NA
How problem was solved, alternative solutions (if any) and why they were rejected
Added a new CMAKE flag XDP_VE2_BUILD_CMAKE based on which the VE2 plugins will be built. The flag will be set from VE2 directory CMake file. Need to create a PR on VE2 repo to set this flag.
Risks (if any) associated the changes in the commit
No risk as the plugins are build only with the CMake flag.
What has been tested and how, request additional testing if necessary
Tested trace and profile for VE2 design using QEMU+AIESIM flow.
Documentation impact (if any)
NA