Fix for CR-1219310 : Spatial sharing overhead test failure on linux #8652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
This PR fixes CR-1219310
The problem was identified as missing init_buffer call which made the instruction buffer have garbage value and causing the device to behave in-deterministically. It makes the test on Windows run as a no-op kernel but behave differently on linux
This PR also cleans up some utility code in TestRunner class and correctly moves it to ValidateUtilities.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
CR-1219310
Discovered through testing on Linux by the Linux folks.
How problem was solved, alternative solutions (if any) and why they were rejected
The problem was solved through correctly using the df-bw control code and modifying the buffer sizes accordingly.
Risks (if any) associated the changes in the commit
N/A
What has been tested and how, request additional testing if necessary
Tested on Windows and linux platforms. Updated metric numbers after testing :
Windows :
Linux :
Documentation impact (if any)
N\A