Add changes to support 32 bit addend address in ELF patching #8649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbramand-xilinx
requested review from
larry9523,
chvamshi-xilinx and
HimanshuChoudhary-Xilinx
chvamshi-xilinx
approved these changes
Dec 10, 2024
stsoe
approved these changes
Dec 10, 2024
larry9523
reviewed
Dec 10, 2024
larry9523
requested changes
Dec 10, 2024
added 2 commits
December 11, 2024 17:17
Signed-off-by: rbramand <[email protected]>
Signed-off-by: rbramand <[email protected]>
rbramand-xilinx
force-pushed
the
xrt_module
branch
from
f2fc943 to
add8364
Compare
Yeah Soren. Discussed with Sonal aswell. He suggested to move all of this code to aiebu and XRT uses functions from it. It is going to take some time :-) |
Hi @larry9523 made changes as discussed, please review |
sonals
approved these changes
Dec 11, 2024
larry9523
approved these changes
Dec 11, 2024
chvamshi-xilinx
pushed a commit
to chvamshi-xilinx/XRT-1
that referenced
this pull request
Dec 31, 2024
Signed-off-by: ch vamshi krishna <[email protected]>
chvamshi-xilinx
added a commit
that referenced
this pull request
Dec 31, 2024
…8676) Signed-off-by: ch vamshi krishna <[email protected]> Co-authored-by: ch vamshi krishna <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved by the commit
Earlier rela dynamic sections addend fields higher 28 bits were used for holding base buffers addend address but 28 bits are not sufficient in all cases.
This change adds support for 32 bit addend.
AIEBU generates new ELF with ABI version 2 which uses rela section entries r_addend for 32 bit addend address and type is used for patching schema. Made changes according to new spec.
Bug / issue (if any) fixed, which PR introduced the bug, how it was discovered
Added support for 32 bit addend
How problem was solved, alternative solutions (if any) and why they were rejected
Ideally moving to 64 bit ELF should solve the problem but it requires lot of changes from both aiebu and XRT side so this is planned for upcoming releases. Also other solutions which breaks existing ELFs are rejected.
This change doesn't cause any issue as there are version checks
Risks (if any) associated the changes in the commit
Low
What has been tested and how, request additional testing if necessary
Tested failing psq2 application and test passes with this fix
Documentation impact (if any)
NA