Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the extension and page/tab icon color based on the selected theme #166

Merged
merged 29 commits into from
Nov 10, 2024

Conversation

prem-k-r
Copy link
Collaborator

@prem-k-r prem-k-r commented Nov 8, 2024

Tested on Windows/Chrome, Edge, Firefox, Brave

Closes #119

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 8, 2024

Not facing any issue but in developer console there is an error
image
@XengShi can you please check
also need to verify that it works in other browsers too

Copy link
Collaborator

@itz-rj-here itz-rj-here left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. I really appreciate your changes. Great work.

@itz-rj-here
Copy link
Collaborator

Not facing any issue but in developer console there is an error
image
@XengShi can you please check
also need to verify that it works in other browsers too

Maybe the format of the image is causing the issue. Try changing the image format if it fixes.

@XengShi
Copy link
Owner

XengShi commented Nov 8, 2024

I think changing png to ico will fix that error

icon path updated
@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 8, 2024

I think changing png to ico will fix that error

It didnt, but I got it.
I was using image 180x180, changed to 128x128, and console error dissapeared.

@prem-k-r prem-k-r marked this pull request as draft November 8, 2024 15:11
@prem-k-r prem-k-r marked this pull request as ready for review November 8, 2024 15:31
@prem-k-r prem-k-r marked this pull request as draft November 8, 2024 15:52
@itz-rj-here
Copy link
Collaborator

huh what changes you did 👀

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 8, 2024

A quick question, does the extension supports in Opera too?

@XengShi
Copy link
Owner

XengShi commented Nov 8, 2024

A quick question, does the extension supports in Opera too?

Yess

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 8, 2024

Ok
I checked on chrome and edge
Currently working:

  • Chrome

    • Tab icon: yes, but for a split second it shows the default blue icon. Have to put it in DOMContentLoaded event. I'll get it to later
    • Extension icon: yes
  • Edge

    • Tab icon: No. Showing white circular zigzag icon for all theme
    • Extension icon: yes

Also I noticed now that the icon I edited, uploaded by RJ had a padding. So icons will appear a little bit smaller. I'll re edit and upload after fixing code

@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 8, 2024

I just installed Firefox to check, and both the tab icon and extension icon color changes are working fine.

Other things I noticed:

@itz-rj-here
Copy link
Collaborator

Idk i just don't use those.

@prem-k-r prem-k-r changed the title Change the page/tab icon color based on the selected theme Change the extension and page/tab icon color based on the selected theme Nov 9, 2024
@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 9, 2024

Ok I checked on chrome and edge Currently working:

  • Chrome

    • Tab icon: yes, but for a split second it shows the default blue icon. Have to put it in DOMContentLoaded event. I'll get it to later
    • Extension icon: yes
  • Edge

    • Tab icon: No. Showing white circular zigzag icon for all theme
    • Extension icon: yes

This edge stuff already in XegShi:main
Checked on brave too, working fine

@prem-k-r prem-k-r marked this pull request as ready for review November 9, 2024 08:58
@prem-k-r
Copy link
Collaborator Author

prem-k-r commented Nov 9, 2024

@XengShi fixed conflicts

@XengShi XengShi merged commit 1d12128 into XengShi:main Nov 10, 2024
@prem-k-r prem-k-r deleted the patch-3 branch November 10, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change page/tab icon according to selected color theme
3 participants