-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the extension and page/tab icon color based on the selected theme #166
Conversation
Change page/tab icon according to selected color theme
Resized
Not facing any issue but in developer console there is an error |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow. I really appreciate your changes. Great work.
Maybe the format of the image is causing the issue. Try changing the image format if it fixes. |
I think changing png to ico will fix that error |
icon path updated
It didnt, but I got it. |
Added back icons, 128x128
used to create favicon folder
missed
huh what changes you did 👀 |
A quick question, does the extension supports in Opera too? |
Yess |
Ok
Also I noticed now that the icon I edited, uploaded by RJ had a padding. So icons will appear a little bit smaller. I'll re edit and upload after fixing code |
I just installed Firefox to check, and both the tab icon and extension icon color changes are working fine. Other things I noticed:
|
Idk i just don't use those. |
Reuploaded icon (removed padding, so little bit bigger size)
This edge stuff already in |
deleted amoled
deleted extra code, used from amoled theme
deleted duplicate code snipet
@XengShi fixed conflicts |
Tested on Windows/Chrome, Edge, Firefox, Brave
Closes #119