-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend/features/home page [DO NOT MERGE!] #89
base: master
Are you sure you want to change the base?
Conversation
This pull request introduces 1 alert when merging 724d6bb into 306ee8f - view on LGTM.com new alerts:
|
@import "login.scss"; | ||
@import "error.scss"; | ||
@import "footer.scss"; | ||
@import "loader"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
@@ -0,0 +1 @@ | |||
@import "main"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files should end with a trailing newline
<div className="container"> | ||
<a className="navbar-brand" href="home.html"> | ||
<img width="150" src="website/static/images/logo.png" /> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unclosed regular expression.
Unrecoverable syntax error. (6% scanned).
@@ -4,6 +4,9 @@ import { | |||
Route | |||
} from "react-router-dom"; | |||
|
|||
import '../stylesheets/main.scss'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
@@ -10,6 +10,7 @@ import Layout from './Layout'; | |||
import Login from './Login'; | |||
import Register from './Register'; | |||
import ForgotPassword from './ForgotPassword'; | |||
import Home from '../pages/Home'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'import' is only available in ES6 (use 'esversion: 6').
This pull request introduces 1 alert when merging 6bf8790 into 306ee8f - view on LGTM.com new alerts:
|
@martavasconcelos if you can generally take over this, would be a great starter ticket |
@ksr89 broken down scss. use react css for non-home pages only. use only home scss for home page;
This change is