fix failing assert in connect RPC
#5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5235 +/- ##
=======================================
Coverage 78.0% 78.0%
=======================================
Files 789 789
Lines 66954 66953 -1
Branches 8108 8105 -3
=======================================
+ Hits 52218 52224 +6
+ Misses 14736 14729 -7
... and 4 files with indirect coverage changes |
ximinez
added
Ready to merge
godexsoft
approved these changes
Jan 14, 2025
src/test/rpc/Connect_test.cpp
Outdated
|
|
||
| BEAST_DEFINE_TESTSUITE(Connect, rpc, ripple); | ||
|
|
||
| } // namespace ripple |
There was a problem hiding this comment.
nit: It's nice to add an empty line at the end to avoid upsetting github here. I usually recommend changing this setting in your favourite IDE (usually called "Insert Final Newline" or something like that).
|
@bthomee this is ready to merge whenever you get a chance |
Bronek
added
the
Ready to merge
bthomee
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
This PR fixes a failing assert scenario in the
connectadmin RPC.Context of Change
When a node is in standalone mode and someone with admin access tries to submit this command, rippled fails an assert (and crashes in debug builds), regardless of what the other parameters are.
Example crashing command:
Type of Change
API Impact
N/A, fixes something that results in a failed assert before
Before / After
Before, use of the
connectRPC on a standalone node fails an assert in rippled. Now, it returns an error.Test Plan
Tested locally.