Migrate some tests to CTest #5216
Open
+940
−946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5216 +/- ##
=========================================
- Coverage 77.9% 77.8% -0.0%
=========================================
Files 783 782 -1
Lines 66677 66577 -100
Branches 8108 8110 +2
=========================================
- Hits 51921 51819 -102
- Misses 14756 14758 +2
... and 8 files with indirect coverage changes |
|
Oh, I'll need to modify the CI to run the CTest tests. For that, I think it makes sense to remove the I might need help fixing the coverage report too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, it is important to define "test". A test should be an executable that returns 0 if and only if it passes. This is the form of test that CTest understands. The purpose of this PR is to configure the project for CTest tests, introduce a third-party battle-tested unit test framework1, and migrate a few existing tests to that framework.
tests/directory for holding tests.src/teststill exists, but the intent is to separate, in the filesystem, CTest tests from everything else.tests/as CTest tests.cryptomodule and some tests of thebasicsmodule totests/.Footnotes
The unit test framework in this PR is doctest, but I'm not married to it. It is easy to switch among any of the popular frameworks like Catch2 or GoogleTest. ↩