Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix levelization script to ignore commented includes #5194

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

vlntb
Copy link
Collaborator

@vlntb vlntb commented Nov 18, 2024

High Level Overview of Change

Issue raised in:
#5193

Context of Change

Added simple check to ignore single-line comments during dependency analysis.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Performance (increase or change in throughput and/or latency)
  • Tests (you added tests for code that already exists, or your new feature included in this PR)
  • Documentation update
  • Chore (no impact to binary, e.g. .gitignore, formatting, dropping support for older tooling)
  • Release

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.0%. Comparing base (9e4a7d5) to head (b6723b3).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #5194   +/-   ##
=======================================
  Coverage     78.0%   78.0%           
=======================================
  Files          789     789           
  Lines        66955   66955           
  Branches      8110    8108    -2     
=======================================
+ Hits         52215   52219    +4     
+ Misses       14740   14736    -4     

see 4 files with indirect coverage changes

Impacted file tree graph

vlntb and others added 2 commits November 27, 2024 16:29
This is a more universal way to detect that the line is commented out.

Co-authored-by: Ed Hennis <[email protected]>
@vlntb vlntb requested a review from ximinez November 27, 2024 16:45
Copy link
Collaborator

@ximinez ximinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice simple fix. Works for me.

Copy link
Collaborator

@Bronek Bronek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ximinez
Copy link
Collaborator

ximinez commented Jan 16, 2025

@vlntb Is this ready to merge? If so, please provide a good commit message to use on the merge.

@vlntb vlntb added the Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required. label Jan 16, 2025
@vlntb vlntb changed the title Fixing levelization.sh script to ignore commented out includes Fix levelization script to ignore commented includes Jan 16, 2025
@bthomee bthomee merged commit 7be5c31 into XRPLF:develop Jan 16, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to merge *PR author* thinks it's ready to merge. Has passed code review. Perf sign-off may still be required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants