-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix levelization script to ignore commented includes #5194
Fix levelization script to ignore commented includes #5194
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #5194 +/- ##
=======================================
Coverage 78.0% 78.0%
=======================================
Files 789 789
Lines 66955 66955
Branches 8110 8108 -2
=======================================
+ Hits 52215 52219 +4
+ Misses 14740 14736 -4 |
This is a more universal way to detect that the line is commented out. Co-authored-by: Ed Hennis <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice simple fix. Works for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@vlntb Is this ready to merge? If so, please provide a good commit message to use on the merge. |
High Level Overview of Change
Issue raised in:
#5193
Context of Change
Added simple check to ignore single-line comments during dependency analysis.
Type of Change
.gitignore
, formatting, dropping support for older tooling)