Replace more deprecated features from GTK 1 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it consistent with next commit.
I haven't found a way to replace it.
Based the GIOChannel support in src/stat.c. (Ignore the FIXME GError comments, they're from src/stat.c.)
|
Thank you very much! ❤️ |
|
It works well on my end! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to try to get XQF working on GTK 3, I updated a lot of code from GTK 1 to GTK 2 which is also compatible with GTK 3.
I mainly worked on this in July 2023. I think the only things left to change for GTK 3 are combo boxes (gtk_combo), gtk_option_menu, list/column views (gtk_ctree/gtk_clist), and GdkPixmap/GdkBitmap. This is kind of the majority of the interface and inconveniently GTK 2/3/4 all have different ways of handling them. Though jumping to GTK 4 has more issues.
A lot of this is based on the guides for GTK Changes from 1.0 to 1.2 and GTK Changes from 1.2 to 2.0. The website is not online as of writing and archive.org doesn't have it. I also checked things in the GTK 2 source for how these legacy GTK 1 features are handled.