Made the GPose fix Release ready.

Improvised fix for #191 commented out for now.
XIV-Tools · Sep 17, 2023 · cc7f5fc · cc7f5fc
1 parent 7d4b9f0
commit cc7f5fc
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 5 deletions.
diff --git a/CustomizePlus/Data/Armature/Armature.cs b/CustomizePlus/Data/Armature/Armature.cs
@@ -234,7 +234,12 @@ public unsafe bool TryLinkSkeleton(bool forceRebuild = false)
             }
             catch
             {
-                PluginLog.LogError($"Error occured while attempting to link skeleton: {this}");
+                // This is on wait until isse #191 on Github responds. Keeping it in code, delete it if I forget and this is longer then a month ago.
+
+                // Disabling this if its any Default Profile due to Log spam. A bit crazy but hey, if its for me id Remove Default profiles all together so this is as much as ill do for now! :)
+                //if(!(Profile.CharacterName.Equals(Constants.DefaultProfileCharacterName) || Profile.CharacterName.Equals("DefaultCutscene"))) {
+                    PluginLog.LogError($"Error occured while attempting to link skeleton: {this}");
+                //}
             }
 
             return false;

diff --git a/CustomizePlus/Data/Profile/CharacterProfile.cs b/CustomizePlus/Data/Profile/CharacterProfile.cs
@@ -80,7 +80,6 @@ public bool AppliesTo(Dalamud.Game.ClientState.Objects.Types.GameObject obj)
             if (obj.Name.TextValue.IsNullOrEmpty() && (obj.ObjectIndex == 200 || obj.ObjectIndex == 201))
             {
                 var test = GameDataHelper.GetCutsceneName(obj);
-                PluginLog.Information("Found Character in 200 or 201." + test + " with type " + test.GetType());
                 //Player is sometimes in 200 sometimes in 201. Don't ask me why.
                 return AppliesTo(test);
             }

diff --git a/CustomizePlus/Helpers/GameDataHelper.cs b/CustomizePlus/Helpers/GameDataHelper.cs
@@ -282,9 +282,8 @@ public unsafe static string GetObjectName(DalamudObject obj)
         /// </summary>
         public static unsafe string GetCutsceneName(DalamudObject gameObject)
         {
-            PluginLog.Verbose($"Its {gameObject.ObjectKind}. Also, Name is: {gameObject.Name.TextValue}");
-            if (gameObject.ObjectKind != DalamudObjectKind.Player &&  gameObject.Name.TextValue != string.Empty) {
-                PluginLog.Verbose($"Found Object that isnt player or Cutscene object. Its {gameObject.ObjectKind}. Also, Name is: {gameObject.Name.TextValue}");
+            if (gameObject.ObjectKind != DalamudObjectKind.Player && gameObject.Name.TextValue != string.Empty) {
+                PluginLog.Verbose($"Found Object that isnt player or Cutscene object. Its {gameObject.ObjectKind}. Also, Name is: {GetInitials(gameObject.Name.TextValue)}");
                 return gameObject.Name.TextValue;
             }
 
@@ -393,6 +392,23 @@ public static unsafe string GetCutsceneName(DalamudObject gameObject)
             return null;
         }
 
+        /// <summary>
+        /// Returns the Initials of what looks like names, aka Player names etc. Simply determined by a Space present.
+        /// If we have no or more then one space, return the full thing.
+        /// This is mainly to be used in Debug messages, to be able to Identify issues without printing a full Player name to log every time.
+        /// </summary>
+        /// <param name="input">The Name to Annonymize.</param>
+        /// <returns>The Initials, or the Full string when more or less then 1 Space.</returns>
+        public static string GetInitials(string input) {
+            string[] nameParts = input.Split(' ');
+
+            if (nameParts.Length == 2) {
+                return $"{nameParts[0][0]}. {nameParts[1][0]}.";
+            } else {
+                return input;
+            }
+        }
+
         /*
 		public static void SetTemporaryCharacterScale(string characterName, CharacterProfile scale)
 		{