FEDX-1709 Batch/fedx/workiva analysis options v2 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pubspec.yaml
Outdated
| @@ -15,6 +15,7 @@ executables: | |||
| dependencies: | |||
| args: ^2.3.0 | |||
| build: ^2.1.0 | |||
| build_runner: ^2.3.3 | |||
There was a problem hiding this comment.
Reason for this change? Doesn't look like there is anything within this PR that would warrant promoting build_runner from a dev dep to a regular dep
There was a problem hiding this comment.
Good catch, I was trying to fix a CI error and this seemed to resolve it, but I think it was something else that fixed it and this didn't get moved back.
matthewnitschke-wk
approved these changes
Nov 11, 2024
|
QA +1
🚀 @Workiva/release-management-p 🚢 |
|
@Workiva/release-management-pp |
robbecker-wf
approved these changes
Nov 15, 2024
|
retry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
This was originally closed here because of failing tests in master, but has been re-implemented with this PR. We are now focusing on implementing v2 for workiva analysis options and commenting out the dart 3 stable and beta CI tests for now. Work to resolve those issues will be handled with FEDX-1911.
What was done
This PR bumps/adds workiva_analysis_options to v2. This is being done in an effort to adopt consistency in {{analysis_options.yaml}} files across the codebase, and ensure all developers are using the most up to date functionality that the dart analyzer can provide.
Failing CI will be evaluated by someone from FEDX and resolved. We will reach out when the pr is ready for review.
(We are stopping dart 3 stable and beta CI tests since they are even failing in master. Future work will resolve this (see Update section above)
If you have any questions, concerns, or opinions, please reach out to #support-frontend-dx.
[Created by Sourcegraph batch change {{Workiva/workiva_analysis_options_v2}}.|https://workiva.sourcegraphcloud.com/organizations/Workiva/batch-changes/workiva_analysis_options_v2]