Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FED-3275 React 18 Prep #170

Merged
merged 5 commits into from
Jan 31, 2025
Merged

FED-3275 React 18 Prep #170

merged 5 commits into from
Jan 31, 2025

Conversation

sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Jan 29, 2025

In preparation for React 18, suppress react_dom.render warnings like in Workiva/react-dart#413 - this is the only thing needed to get tests passing in over_react_test on React 18

QA instructions

@sydneyjodon-wk sydneyjodon-wk changed the title Test React 18 FED-3275 Test React 18 Jan 29, 2025
@sydneyjodon-wk sydneyjodon-wk changed the title FED-3275 Test React 18 FED-3275 React 18 Prep Jan 30, 2025
@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review January 30, 2025 00:28
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@sydneyjodon-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@btr-rmconsole-1 btr-rmconsole-1 bot merged commit a5f567f into master Jan 31, 2025
4 checks passed
@btr-rmconsole-1 btr-rmconsole-1 bot deleted the react-18-test branch January 31, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants