Remove jQuery from user-notes.js
#530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| scrollTop: pos.top - wpAdminBar - 16 | ||
| }, 1 ); | ||
| // Scroll to comment if comment date link is clicked. | ||
| document.querySelectorAll( '#comments .comment-date' ).forEach( ( element ) => { |
There was a problem hiding this comment.
I don't believe this code path is even working anymore as I can't find the #comments parent. Do I have that wrong?
Should we remove this smooth scrolling if that is the case?
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Remove jQuery from
user-notes.jsWhy
jQuery is known to inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality.