Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set yarn version to v1 (classic) #528

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Jul 22, 2024

Run the following command to ensure that the correct yarn version is
used when using the project on machines that have newer yarn versions
installed:

yarn set version classic

Without this change, newer yarn versions would not work well with this repo,
and would automatically attempt to upgrade the lockfile.


Alternatively, this project could switch to newer versions of yarn or recent versions of npm. Other WordPress projects are using npm and that may be preferable.

Run the following command to ensure that the correct yarn version is
used when using the project on machines that have newer yarn versions
installed:

```sh
yarn set version classic
```
Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!


Alternatively, this project could switch to newer versions of yarn or recent versions of npm. Other WordPress projects are using npm and that may be preferable.

We have yarn baked in to a few places (and used on all our other projects) - i agree npm would be preferable, but it's a bigger change to do that, so this is a good middle step.

@ryelle ryelle merged commit bdac381 into WordPress:trunk Jul 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants