Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the position of the Table of Contents #522

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

adamwoodnz
Copy link
Contributor

@adamwoodnz adamwoodnz commented Jun 10, 2024

A change in Gutenberg 18.5 broke the 3 column layout which controls the position of the table of contents. This PR updates the templates to be compatible with the changes to the 3 column layout in the parent theme.

See WordPress/wporg-parent-2021#139

Depends on WordPress/wporg-parent-2021#140 and WordPress/wporg-mu-plugins#624

Screenshots

Before After
developer wordpress org_reference_functions_add_theme_support_ developer wordpress org_reference_functions_add_theme_support_ (1)

@adamwoodnz adamwoodnz self-assigned this Jun 10, 2024
@adamwoodnz adamwoodnz changed the title Fix 3 column layout for compatibility with Gutenberg 18.5 Fix 3 column layout compatibility with Gutenberg 18.5 Jun 10, 2024
@adamwoodnz adamwoodnz changed the title Fix 3 column layout compatibility with Gutenberg 18.5 Fix the positioning of the Table of Contents Jun 10, 2024
@adamwoodnz adamwoodnz changed the title Fix the positioning of the Table of Contents Fix the position of the Table of Contents Jun 10, 2024
Copy link
Contributor

@ryelle ryelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍🏻

@adamwoodnz adamwoodnz merged commit 4d5a178 into trunk Jun 11, 2024
1 check passed
@adamwoodnz adamwoodnz deleted the fix/toc-position-gutenberg-18-5 branch June 11, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants