Fix labeling of the command palette. #56718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Type] Bug
|
Size Change: +57 B (0%) Total Size: 1.72 MB
ℹ️ View Unchanged
|
afercia
force-pushed
the
fix/command-palette-labeling
branch
from
0e10513 to
d1d5cd6
Compare
|
In the latest commit I'm removing a nested Nested Listboxes are a problem as explained in this comment on the related issue. Also, labeling the nested Listboxes would make things worse. Screenshots from the 'Accessibility Tree view' in Chrome dev tools to illustrate the previous incorrect nesting where the main Listbox contains a mix of options and other Listboxes:
After: where the semantic structure is cleaner and more correct: One Listbox that only contains a group and options:
|
youknowriad
reviewed
Dec 5, 2023
| 'aria-label', | ||
| __( 'Command suggestions' ) | ||
| ); | ||
| }, [ commandListRef.current ] ); |
There was a problem hiding this comment.
Is this really necessary, I'd prefer if we avoid this hack personally. We're updating a DOM node controller by React using an imperative API, this can break in different ways. (For example, if the component is re-rendered, these things could get reset).
There was a problem hiding this comment.
@youknowriad Yes I know it's hacky 😞 I reported the root problem upstream at pacocoursey/cmdk#196. If you could maybe help getting the cmdk team release a fix soon we could entirely avoid this hack
|
If the upstream issue is holding this back, do you think it would be a good idea to open a new pull request that solves the incorrect nesting separately? |
|
Yes we can try submit a pull request upstream. |
|
Together with @carolinan and @SergeyBiryukov we submitted a pull request upstream to solve the labeling issue. See pacocoursey/cmdk#204 I'd propose to wait a few days to see if it gets approved and released timely so that we can update the |
|
@youknowriad when you have a chance 🙏 do you have any contact at the upstream |
|
The upstream PR has been merged into the |
youknowriad
approved these changes
Feb 8, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core SVNCore Committers: Use this line as a base for the props when committing in SVN: GitHub Merge commitsIf you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Thanks Riad. Sure, I just subscribed to get notifications for new Cmdk releases. |
|
Thanks @afercia btw, check this post for next PRs https://make.wordpress.org/core/2024/02/01/new-commit-message-requirements-in-git-hello-props-bot/ |
|
Yes sorry I did that in a previous PR and forgot on this one 😞 |
|
Just wanted you to be aware of it in case you didn't, I don't mind mistakes as we build muscle memory. |
|
Yes sure, thanks. It's just difficult to get used to, for now 🙂 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes this issue: #54502
What?
Why?
Correct labelling of ARIA widgets and form controls is fundamental for basic accessibility.
How?
Testing Instructions
role="dialog"is labeledCommand palette.Search for commands.role="listbox"is labeledCommand suggestions.Testing Instructions for Keyboard
Screenshots or screencast