Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor method for better windows compatibility #63

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

reimic
Copy link
Collaborator

@reimic reimic commented Mar 5, 2024

Refactor method move_files_from_directory_to_directory to enhance Windows compatibility.

Method will:

  • use Filesystem's rename which handles various operating system better then the replaced core PHP method,
  • canonicalize paths for better Windows compatibility.

@reimic reimic added enhancement New feature or request tests and removed tests labels Mar 5, 2024
@adamziel adamziel merged commit 4517a17 into WordPress:trunk Mar 5, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants