Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Unzip Step #57

Merged
merged 1 commit into from
Mar 7, 2024
Merged

Test Unzip Step #57

merged 1 commit into from
Mar 7, 2024

Conversation

reimic
Copy link
Collaborator

@reimic reimic commented Mar 2, 2024

What does this PR do?

  • Adds tests for the the UnzipStep.
  • Refactors the UnzipStepRunner to require a progress tracker and handle extraxt_to_path in both relative and absolute form.
  • Downgrades code where necessary to properly function for all PHP versions >= 7.4.
  • Adds test resources. (For now in the Step directory - TBD where test resources will be stored.)
  • Takes care of a TODO by canonicalizing a path in the zip_extract_to function.

@reimic reimic marked this pull request as ready for review March 4, 2024 14:23
@reimic
Copy link
Collaborator Author

reimic commented Mar 4, 2024

image

This is very interesting and proves the usefulness of a matrix test step. My local environment is set to PHP 7.4 and when I run those tests they pass without issue. But they do fail here. This is critical info and I am glad it is there. (Someone really wise must've implemented it.)

@reimic reimic force-pushed the zip branch 2 times, most recently from 30b3644 to 4009bbc Compare March 5, 2024 15:28
@reimic
Copy link
Collaborator Author

reimic commented Mar 5, 2024

This PR became more about downgrading PHP than testing the Unzip Step. But that is a good thing, as downgrading the code becomes a priority. As a bonus - the matrix proved its usefulness.

@reimic reimic added the tests label Mar 5, 2024
@adamziel
Copy link
Collaborator

adamziel commented Mar 5, 2024

src/WordPress/Blueprints/Model/DataClass/UnzipStep.php is autogenerated, let's revert all the changes applied to it.

@reimic reimic changed the title Test Zip-related Steps Test Unzip Step Mar 6, 2024
@adamziel adamziel merged commit d1e32e6 into WordPress:trunk Mar 7, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants