Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch up with WCT 0.20.0 (IDFT) #31

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

HaiwangYu
Copy link
Member

  • Use Eigen instead of (WireCell::Array) in KokkosArray_fftw
  • Use IDFT interfaces in several pieces of code
  • wct-sim.jsonnet updated
    A rough test with WCT 0.20.0 following this wiki page looks like this:

Screen Shot 2022-07-14 at 1 37 27 PM

@zhihuadong
Copy link
Contributor

zhihuadong commented Jul 18, 2022

When build with spack installed [email protected]. Compile failed could not find "WireCellAux/SimpleTrace":
[ 4%] Building CXX object CMakeFiles/WireCellGenKokkos.dir/work/zdong/git/wc_gen_kk/src/DepoTransform.cxx.o /usr/bin/g++ -DBOOST_ALL_NO_LIB -DKOKKOS_DEPENDENCE -DWireCellGenKokkos_EXPORTS -I/work/zdong/git/wc_gen_kk/.cmake-kokkos-omp/../inc -I/work/zdong/git/spack2/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/fftw-3.3.10-lrxhdn33qprm6csp2hhtueagaizrggo7/include -I/work/zdong/git/spack2/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/eigen-3.4.0-sfhg4zape4s2o4lfzfcmv62rdxs4xcag/include/eigen3 -I/work/zdong/git/spack2/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/jsoncpp-1.9.4-uspwugyn3tkyksk52zvnppzbzaporbvk/include -I/work/zdong/git/spack2/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/go-jsonnet-0.18.0-mnngcydlmz6cych2rzlo6wuhz5tyqsrm/include -I/work/zdong/git/spack2/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/spdlog-1.9.2-6e4dzaqjo4sr4fbwjj4jftmldjwgxhtt/include -I/work/zdong/git/spack2/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/wire-cell-toolkit-0.20.0-fk6wnqgwz4kvizjrvwevbiwvutyhbikp/include -isystem /work/zdong/git/spack2/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/boost-1.79.0-mir7iqabxibzghtwphvzastzjbu4jkft/include -isystem /home/zdong/PPS/install/kokkos-3.3.01-openmp-gcc-9.3.0-zen2/include -g -O2 -fopenmp -pedantic -Wall -fPIC -DEIGEN_NO_CUDA -DEIGEN_FFTW_DEFAULT=1 -DEIGEN_DONT_VECTORIZE -fopenmp -march=znver2 -mtune=znver2 -std=c++17 -o CMakeFiles/WireCellGenKokkos.dir/work/zdong/git/wc_gen_kk/src/DepoTransform.cxx.o -c /work/zdong/git/wc_gen_kk/src/DepoTransform.cxx /work/zdong/git/wc_gen_kk/src/DepoTransform.cxx:44:10: fatal error: WireCellAux/SimpleTrace.h: No such file or directory 44 | #include "WireCellAux/SimpleTrace.h" | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated.
In SPACK area

ls /work/zdong/git/spack2/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/wire-cell-toolkit-0.20.0-fk6wnqgwz4kvizjrvwevbiwvutyhbikp/include/WireCellAux/
ClusterHelpers.h DftTools.h FrameTools.h PlaneSelector.h Rand.h Semaphore.h SimpleTensorSet.h TaggedFrameTensorSet.h TensorPacker.h TensorTools.h Testing.h WaveformMap.h DepoTools.h FftwDFT.h Logger.h PlaneTools.h RandTools.h SimpleTensor.h Spectra.h TaggedTensorSetFrame.h TensorSetUnpacker.h TensUtil.h Util.h

@HaiwangYu
Copy link
Member Author

Hi @zhihuadong, thanks for the catch. I just made a wct 0.21.0 release. You can install that by

spack install [email protected]
spack load [email protected]

You can also add a line to make it a "safe version" I think:
https://github.com/WireCell/wire-cell-spack/pull/6/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants