Fix - Query - Chunked - Resolved infinite loop when start chunk > 1 #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolved an issue when the start chunks value was > 1 an infinite loop would be created as handled messages would always be less than available messages when chunks are skipped. Added more safety around input arguments, forcing minimums of 1 for both $chunk_size and $start_chunk.
|
Naturally the additional safety (minimums for arguments) might be a breaking change for some use cases, so that part is at the maintainers discretion. Absolutely happy to refactor if that is a problem :) |
NeekTheNook
changed the title
|
Hi @NeekTheNook , Best regards & happy coding, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved an issue when the start chunks value was > 1 an infinite loop would be created as handled messages would always be less than available messages.
Added more safety around input arguments, forcing minimums of 1 for both $chunk_size and $start_chunk.