Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add end2end tests #470

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Add end2end tests #470

wants to merge 4 commits into from

Conversation

camillobruni
Copy link
Contributor

@camillobruni camillobruni commented Jan 7, 2025 •
edited
Loading

  • Move unitests to run-unittests.mjs
  • Move common test driver and server setup to separate helper.mjs module
  • Add SpeedometerReady and SpeedometerDone events for easier testing
  • Add simple end2end tests

flashdesignory
flashdesignory approved these changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@flashdesignory flashdesignory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

resources/shared/benchmark.mjs Outdated Show resolved Hide resolved
@bgrins bgrins requested a review from julienw January 7, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flashdesignory flashdesignory flashdesignory approved these changes

@bgrins bgrins Awaiting requested review from bgrins

@julienw julienw Awaiting requested review from julienw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@camillobruni @flashdesignory