split TestInvokerClass into a separate file #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flashdesignory
requested review from
julienw,
camillobruni,
rniwa and
bgrins
and removed request for
julienw and
camillobruni
bgrins
approved these changes
Nov 12, 2024
rniwa
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To prepare further for the remote workloads / postMessage feature, I'd like to separate out the test invokers from the benchmark-runner. This will reduce duplicate code, since workloads will re-use (import) the same test invoker classes to run the tests themselves.
Since the test invokers are self-contained now, I am passing in the params object, which the classes rely on.