Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Runner cleanup - for our internal tests #446

Merged
merged 7 commits into from
Nov 6, 2024

Conversation

flashdesignory
Copy link
Contributor

Currently, if tests fail when running npm run test:chrome, ect we don't get a good reporting in the node console.
Especially, if a test fails, we don't get any details.

current pass:
Screenshot 2024-11-05 at 10 47 11 AM

current fail:
Screenshot 2024-11-05 at 10 47 50 AM

A cleanup can give us similar (simplified) reporting, as the browser window displays.

new pass:
Screenshot 2024-11-05 at 11 25 53 AM

new fail:
Screenshot 2024-11-05 at 11 25 40 AM

Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like an improvement.

@flashdesignory flashdesignory merged commit 94f0d81 into WebKit:main Nov 6, 2024
4 checks passed
@flashdesignory flashdesignory deleted the test/cleanup branch November 6, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants