Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SuiteRunner: use suite instance variables #437

Merged
merged 3 commits into from
Oct 29, 2024
Merged

SuiteRunner: use suite instance variables #437

merged 3 commits into from
Oct 29, 2024

Conversation

camillobruni
Copy link
Contributor

No description provided.

flashdesignory
flashdesignory approved these changes Oct 22, 2024
View reviewed changes
Copy link
Contributor

@flashdesignory flashdesignory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@camillobruni camillobruni requested a review from julienw October 22, 2024 15:25
julienw
julienw approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the cleanup!

@camillobruni camillobruni merged commit 617c731 into WebKit:main Oct 29, 2024
4 checks passed
@camillobruni camillobruni deleted the 2024-10-22_improve_runner branch October 29, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienw julienw julienw approved these changes

@flashdesignory flashdesignory flashdesignory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camillobruni @flashdesignory @julienw