Make the github action linter step fail in the case of issues #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julienw
force-pushed
the
fix-linter-in-ci
branch
3 times, most recently
from
93f67b1 to
6dfb051
Compare
julienw
force-pushed
the
fix-linter-in-ci
branch
4 times, most recently
from
fe25be4 to
4389731
Compare
julienw
force-pushed
the
fix-linter-in-ci
branch
2 times, most recently
from
46174ab to
a41f0e0
Compare
rniwa
approved these changes
Feb 16, 2024
camillobruni
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the github action runs the formatter, but doesn't check that anything was actually reformatted as a result. So it was always successful.
To fix the issue, my strategy is to run a special form of
git statuswhose output won't change over time. If the output is empty, this means that there's no change. Otherwise the action outputs some helpful diagnostics.Here are examples of output:
Failing: https://github.com/WebKit/Speedometer/actions/runs/7920439286/job/21623479161?pr=374
Successful: https://github.com/WebKit/Speedometer/actions/runs/7920372392/job/21623262244?pr=374