Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add separate about.html and instructions.html #359

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 39 additions & 0 deletions index.html
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
</div>
<div class="button-row">
<a href="#about">About Speedometer</a>
<a href="#instructions">Test Instructions</a>
</div>
</div>
</section>
Expand Down Expand Up @@ -176,6 +177,44 @@ <h1 class="section-header">About Speedometer 3</h1>
</div>
</div>
</section>

<section id="instructions" data-title="Test Instructions">
<a href="#home" class="logo">
<img srcset="resources/[email protected] 2x" src="resources/logo.png" alt="Speedometer" />
<div class="version">3.0</div>
</a>
<div class="section-grid">
<h1 class="section-header">Speedometer 3 Test Instructions</h1>
<div class="section-content">
<h2>General Instructions</h2>
<ol>
<li>Before running Speedometer:</li>
<ul>
<li>Close all other applications.</li>
<li>Close other browser windows and tabs.</li>
<li>Use a fresh browser profile and a single window.</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to explicitly call out that browser extensions should be disabled?

</ul>
<li>While running Speedometer:</li>
<ul>
<li>Keep the browser window in the foreground.</li>
<li>Do not use any other applications while Speedometer runs.</li>
</ul>
</ol>

<!-- TODO: fill in detailed instructions
<h2>Detailed browser-specific instructions</h2>
<h3>Chrome</h3>
<h3>Edge</h3>
<h3>Firefox</h3>
<h3>Safari</h3>
--></div>
<div class="buttons section-footer">
<div class="button-row">
<a class="button" href="#home" title="Show main section.">Home</a>
</div>
</div>
</div>
</section>
</main>
</body>
</html>
3 changes: 2 additions & 1 deletion resources/main.css
Original file line number Diff line number Diff line change
Expand Up @@ -532,7 +532,8 @@ section#details h1 {
margin-bottom: 10px;
}

section#about h1 {
section#about h1,
section#instructions h1 {
margin-top: 10px;
margin-bottom: 0px;
font-size: 25px;
Expand Down
3 changes: 2 additions & 1 deletion resources/main.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ class MainBenchmarkClient {
return;
}
} else {
if (hash !== "" && hash !== "#home" && hash !== "#about") {
// Redirect invalid views to #home directly.
if (hash === "#running" || hash === "#summary" || hash === "#details") {
this._setLocationHash("#home");
return;
}
Expand Down
Loading