-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate about.html and instructions.html #359
Merged
camillobruni
merged 8 commits into
WebKit:main
from
camillobruni:2024-01-25_instructions_section
Feb 2, 2024
Merged
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
859bfca
add basic instructions
camillobruni 69350b6
updating css
camillobruni 4d9914c
Merge remote-tracking branch 'webkit/main' into 2024-01-25_instructio…
camillobruni 030b95a
navigation fix
camillobruni c2f98be
adding separate pages
camillobruni 403bb94
Merge remote-tracking branch 'webkit/main' into 2024-01-25_instructio…
camillobruni 16354a2
adding about
camillobruni 5e80548
fix css
camillobruni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,6 +30,7 @@ | |
</div> | ||
<div class="button-row"> | ||
<a href="#about">About Speedometer</a> | ||
<a href="#instructions">Test Instructions</a> | ||
</div> | ||
</div> | ||
</section> | ||
|
@@ -176,6 +177,44 @@ <h1 class="section-header">About Speedometer 3</h1> | |
</div> | ||
</div> | ||
</section> | ||
|
||
<section id="instructions" data-title="Test Instructions"> | ||
<a href="#home" class="logo"> | ||
<img srcset="resources/[email protected] 2x" src="resources/logo.png" alt="Speedometer" /> | ||
<div class="version">3.0</div> | ||
</a> | ||
<div class="section-grid"> | ||
<h1 class="section-header">Speedometer 3 Test Instructions</h1> | ||
<div class="section-content"> | ||
<h2>General Instructions</h2> | ||
<ol> | ||
<li>Before running Speedometer:</li> | ||
<ul> | ||
<li>Close all other applications.</li> | ||
<li>Close other browser windows and tabs.</li> | ||
<li>Use a fresh browser profile and a single window.</li> | ||
</ul> | ||
<li>While running Speedometer:</li> | ||
<ul> | ||
<li>Keep the browser window in the foreground.</li> | ||
<li>Do not use any other applications while Speedometer runs.</li> | ||
</ul> | ||
</ol> | ||
|
||
<!-- TODO: fill in detailed instructions | ||
<h2>Detailed browser-specific instructions</h2> | ||
<h3>Chrome</h3> | ||
<h3>Edge</h3> | ||
<h3>Firefox</h3> | ||
<h3>Safari</h3> | ||
--></div> | ||
<div class="buttons section-footer"> | ||
<div class="button-row"> | ||
<a class="button" href="#home" title="Show main section.">Home</a> | ||
</div> | ||
</div> | ||
</div> | ||
</section> | ||
</main> | ||
</body> | ||
</html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want to explicitly call out that browser extensions should be disabled?