Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CVE-2023-26159 in follow-redirects 1.15.2 #355

Conversation

issackjohn
Copy link
Contributor

@issackjohn issackjohn commented Jan 24, 2024

Affected files:

  • package-lock.json
  • /resources/newssite/news-next/package-lock.json
  • /resources/newssite/news-site-css/package-lock.json
  • /resources/todomvc/architecture-examples/angular/package-lock.json
  • /resources/todomvc/architecture-examples/backbone/package-lock.json
  • /resources/todomvc/architecture-examples/backbone-complex/package-lock.json
  • /resources/todomvc/architecture-examples/preact/package-lock.json
  • /resources/todomvc/architecture-examples/preact-complex/package-lock.json
  • /resources/todomvc/architecture-examples/react/package-lock.json
  • /resources/todomvc/architecture-examples/react-complex/package-lock.json
  • /resources/todomvc/architecture-examples/react-redux/package-lock.json
  • /resources/todomvc/architecture-examples/react-redux-complex/package-lock.json
  • /resources/todomvc/architecture-examples/svelte/package-lock.json
  • /resources/todomvc/architecture-examples/svelte-complex/package-lock.json
  • /resources/todomvc/architecture-examples/vue/package-lock.json
  • /resources/todomvc/architecture-examples/vue-complex/package-lock.json
  • /resources/todomvc/big-dom-generator/package-lock.json
  • /resources/todomvc/todomvc-css/package-lock.json
  • /resources/todomvc/vanilla-examples/javascript-es5/package-lock.json
  • /resources/todomvc/vanilla-examples/javascript-es5-complex/package-lock.json
  • /resources/todomvc/vanilla-examples/javascript-es6-webpack/package-lock.json
  • /resources/todomvc/vanilla-examples/javascript-es6-webpack-complex/package-lock.json
  • /resources/todomvc/vanilla-examples/javascript-web-components/package-lock.json
  • /resources/todomvc/vanilla-examples/javascript-web-components-complex/package-lock.json

closes #351

@issackjohn issackjohn marked this pull request as ready for review January 24, 2024 22:23
@rniwa rniwa added the trivial change A change that doesn't affect benchmark results label Jan 24, 2024
@bgrins
Copy link
Contributor

bgrins commented Jan 24, 2024

Perhaps we should find a new static development http server module since http-server isn't receiving updates and we have very few features we actually need for local development, but this looks like a simple fix in the meantime.

@rniwa
Copy link
Member

rniwa commented Jan 24, 2024

Adding "trivial change" label since this doesn't affect the actual benchmark content.

@issackjohn
Copy link
Contributor Author

FYI: javascript-web-components & news-next had http-server listed as a dependency so I used npm install follow-redirects there instead of npm install follow-redirects --save-dev

@julienw
Copy link
Contributor

julienw commented Jan 25, 2024

It's not clear to me why you added follow-redirects as direct dependencies instead of just updating the package-lock file. npm audit fix should do this for you... including updating other things - we actually have others CVE (babel, semver, word-wrap, to mention only the ones at the top level), so why updating just follow-redirects?

BTW we're not affected by this specific CVE, because as you mentioned, follow-redirects is used for the proxy feature (and just if it's configured to follow redirects), but we're not using it.

@issackjohn issackjohn mentioned this pull request Jan 25, 2024
@julienw
Copy link
Contributor

julienw commented Jan 30, 2024

Outdated by #360

@julienw julienw closed this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CVE-2023-26159 in follow-redirects 1.15.2
5 participants