Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update document title #354

Merged
merged 10 commits into from
Jan 25, 2024
Merged

Update document title #354

merged 10 commits into from
Jan 25, 2024

Conversation

camillobruni
Copy link
Contributor

Add a data-title to each section to update document.title.

@camillobruni camillobruni requested a review from julienw January 24, 2024 20:22
@camillobruni camillobruni added the trivial change A change that doesn't affect benchmark results label Jan 24, 2024
rniwa
rniwa reviewed Jan 24, 2024
View reviewed changes
resources/main.mjs Outdated Show resolved Hide resolved
rniwa
rniwa reviewed Jan 25, 2024
View reviewed changes
resources/main.mjs Outdated Show resolved Hide resolved
julienw
julienw approved these changes Jan 25, 2024
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as @rniwa but otherwise this looks good to me with the new code.

@camillobruni camillobruni merged commit 638a968 into WebKit:main Jan 25, 2024
4 checks passed
@camillobruni camillobruni deleted the 2024-01-24_title_support branch January 25, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rniwa rniwa rniwa approved these changes

@bgrins bgrins bgrins left review comments

@julienw julienw julienw approved these changes

Assignees
No one assigned
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@camillobruni @bgrins @rniwa @julienw