Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small lint-related fixes #350

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Small lint-related fixes #350

merged 5 commits into from
Jan 23, 2024

Conversation

julienw
Copy link
Contributor

@julienw julienw commented Jan 22, 2024

Here are a few fixes for small problems I found while working on the project lately.
Commits should be fairly independent so feel free to look at them separately.

  1. Remove tentative/ from the ignore lists. Indeed there's no tentative workload anymore, but working on some on local branches I find it easier that prettier and eslint are not disabled on these directories.
  2. This makes tsx files checked by the eslint, as well as mirror the check with the fix configuration.
  3. It's good practice to put root: true on the top level eslint configuration file. Reference: https://eslint.org/docs/latest/use/configure/configuration-files#cascading-and-hierarchy
  4. While running eslint, I found this false positive about the next eslint plugin. It was due to a misconfiguration in the newssite-next directory, so I fixed this in the process.
  5. Some file wasn't properly formatted.

Copy link
Contributor

@flashdesignory flashdesignory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@julienw
Copy link
Contributor Author

julienw commented Jan 22, 2024

I believe just one r+ is enough for this, right?

@rniwa rniwa added the trivial change A change that doesn't affect benchmark results label Jan 22, 2024
@rniwa
Copy link
Member

rniwa commented Jan 22, 2024

I believe just one r+ is enough for this, right?

In theory, yes.

@julienw
Copy link
Contributor Author

julienw commented Jan 23, 2024

2 r+ is more than enough then :) thanks for the reviews

@julienw julienw merged commit 7c0931e into WebKit:main Jan 23, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants