Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty hash for cleaner default URLs on the home screen #349

Merged
merged 6 commits into from
Jan 17, 2024
Merged

Allow empty hash for cleaner default URLs on the home screen #349

merged 6 commits into from
Jan 17, 2024

Conversation

camillobruni
Copy link
Contributor

This makes sure we don't have to add #home by default.

@camillobruni camillobruni requested a review from julienw January 16, 2024 14:15
@camillobruni camillobruni added the trivial change A change that doesn't affect benchmark results label Jan 16, 2024
julienw
julienw approved these changes Jan 16, 2024
View reviewed changes
resources/main.css Outdated Show resolved Hide resolved
resources/main.mjs Outdated Show resolved Hide resolved
@camillobruni camillobruni merged commit 4b451d8 into WebKit:main Jan 17, 2024
4 checks passed
@camillobruni camillobruni deleted the 2024-01-16_home_empty_hash branch January 17, 2024 09:33
@camillobruni camillobruni mentioned this pull request Jan 25, 2024
Merged
@mstange mstange mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienw julienw julienw approved these changes

@rniwa rniwa rniwa approved these changes

Assignees
No one assigned
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camillobruni @rniwa @julienw