Always instantiate Float32Array in the cost array of findOptimalSegmentationInternal. #342
Conversation
| @@ -674,7 +674,7 @@ addMetric(metric){this._metrics.push(metric);} | |||
| isHidden(){return this._hidden;}} | |||
| if(typeof module!='undefined') | |||
| module.exports.Test=Test;class Metric extends LabeledObject{constructor(id,object) | |||
| {super(id,object);this._aggregatorName=object.aggregator;object.test.addMetric(this);this._test=object.test;this._platforms=[];const suffix=this.name().match('([A-z][a-z]+|FrameRate)$')[0];this._unit={'FrameRate':'fps','Runs':'/s','Time':'ms','Duration':'ms','Malloc':'B','Heap':'B','Allocations':'B','Size':'B','Score':'pt','Power':'W',}[suffix];} | |||
| {super(id,object);this._aggregatorName=object.aggregator;object.test.addMetric(this);this._test=object.test;this._platforms=[];const suffix=this.name().match('([A-Z][a-z]+|FrameRate)$')[0];this._unit={'FrameRate':'fps','Runs':'/s','Time':'ms','Duration':'ms','Malloc':'B','Heap':'B','Allocations':'B','Size':'B','Score':'pt','Power':'W',}[suffix];} | |||
There was a problem hiding this comment.
Huh, this is a weird typo in the built script. I wonder how that happened?
There was a problem hiding this comment.
As discussed in the meeting, this was likely from not regenerating the output after fixing it in #282 .
…ntationInternal. findOptimalSegmentationInternal's cost array was intended to always contain Float32Array instead of mixture of normal Array and Float32Array. This PR fixes it for the very first element in the cost array, which was erroneously creating a normal Array This PR also fixes a typo in the regular expression of the bundled script where it had [A-z] instead of [A-Z].
rniwa
force-pushed
the
fix-segmentation-float32array
branch
from
fb6e6b2 to
9c4c2be
Compare
Chrome 120.0.6099.199Before After Firefox 121.0.1Before After Safari 17.2Before After |
|
Do you have more context about this change? My understanding is that it's a fairly trivial change, please tell me if there's anything more than consistency. |
The context is that |
|
Ok so it's clearly trivial |
|
@rniwa can you fix the same problem in JetStream too? |
Hm... I guess that would probably mean releasing JetStream 2.2 since 2.1 is already out? I'd create a PR but I'd leave it to folks maintaining JetStream to weigh in. |
|
Made a PR for JetStream 2 at WebKit/WebKit#22688 |
No description provided.