[Complex-Dom] Combine visibility: hidden and display: none for side TreeView hidden elements. #327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpardosixtosMs
changed the title
Before and after results
Comparison to standalone versions
|
julienw
reviewed
Oct 19, 2023
resources/todomvc/big-dom-generator/src/components/tree-area.jsx
Outdated
Show resolved
Hide resolved
julienw
approved these changes
Oct 27, 2023
resources/todomvc/big-dom-generator/src/components/tree-area.jsx
Outdated
Show resolved
Hide resolved
flashdesignory
approved these changes
Oct 27, 2023
There was a problem hiding this comment.
thanks @julienw for all the questions, that made it easier to somewhat follow along.
rniwa
approved these changes
Oct 31, 2023
|
@julienw I addressed all your feedback, I'll go ahead and merge the PR now. Please let me know if there are any more changes you'd like to see in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion on #316 this PR adds a new class name to TreeView elements that should be hidden using
display: none.After this change the sidebar has 6004 elements and 2996 of them had the
display: nonevalue or are descendants of elements withdisplay: nonevalue.Hosted version: https://lpardosixtosms.github.io/SpeedometerHiddenNone/#home