Todomvc svelte cleanup

[flashdesignory]

Some cleanup items from this pr: tastejs/todomvc#2194
Since the changes are coming directly from the Svelte team, it would be beneficial to align.

three items I didn't carry over to Speedometer:

1. uuid: I kept our implementation
2. vite: I didn't touch rollup, which is used here

scores
chrome before:

chrome after:

safari before:

safari after:

firefox before:

firefox after:

edge before:

edge after:

@kara

[julienw]

Interesting that these simple changes make the app so much faster. Looks like that using idiomatic structures helps svelte compile the app to more efficient code.

Should you regenerate the complex version of svelte too?

Small request: can you add

watch: {
  clearScreen: false,
}

to the rollup config
so that npm run dev keeps the server URL displayed?

Thanks :-)

[flashdesignory]

@julienw - let me know if this works for you

[julienw]

I believe this works but what is the advantage compared to adding it to the config?

[flashdesignory]

it threw an error for me 🤷

[julienw]

very weird because this worked for me:

diff --git a/resources/todomvc/architecture-examples/svelte/rollup.config.js b/resources/todomvc/architecture-examples/>
index b9bf6c67..4c1f9c26 100644
--- a/resources/todomvc/architecture-examples/svelte/rollup.config.js
+++ b/resources/todomvc/architecture-examples/svelte/rollup.config.js
@@ -12,16 +12,19 @@ const production = !process.env.ROLLUP_WATCH;
 export default {
     input: "src/index.js",
     output: {
         file: "dist/app.js",
         format: "iife",
         sourcemap: true,
         name: "app",
     },
+    watch: {
+        clearScreen: false,
+    },
     plugins: [
         css({
             minify: true,
         }),
         svelte({
             include: "src/**/*.svelte",
         }),
         resolve({

[flashdesignory]

maybe it took a while for the coffee to kick in, but I moved it in the config and it works of course.

[flashdesignory]

@lpardosixtosMs - this change happened when I ran npm install, to be able to rebuild the new svelte version.

[issackjohn]

That is okay. We've removed jsdom as a devDependency in package.json. I was using npm ci which doesn't update the lock files.

[julienw]

This makes me think that we probably want npm install and not npm ci when updating the complex versions. Indeed we might run into problems when adding dependencies to the big-dom-generator. It would be good to double check.