Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable complex DOM benchmarks execution in official speedometer run #271

Conversation

issackjohn
Copy link
Contributor

@issackjohn issackjohn commented Jul 5, 2023

Selected TodoMVC tests for complex setting

  • Angular
  • JavaScript-ES6-Webpack
  • Lit
  • Preact
  • React
  • Svelte

Selected TodoMVC tests for the stand-alone setting

  • WebComponents
  • JavaScript-ES5
  • React-Redux
  • Backbone
  • Vue
  • jQuery

Hosted version: https://issackjohn.github.io/SpeedometerWithComplex/#home

@issackjohn issackjohn marked this pull request as ready for review July 5, 2023 19:11
@issackjohn issackjohn added the major change A change with major implications on benchmark results or affect governance policy label Jul 5, 2023
@issackjohn
Copy link
Contributor Author

Added major change label: #264 (comment)

@issackjohn issackjohn force-pushed the issackjohn/EnableTestSuitesForComplexDOMVersions branch 3 times, most recently from 81ee6b3 to 98e117b Compare July 8, 2023 00:44
@issackjohn issackjohn changed the title Issackjohn/enable test suites for complex dom versions Enable complex DOM benchmarks executions in official speedometer run Jul 12, 2023
@issackjohn issackjohn changed the title Enable complex DOM benchmarks executions in official speedometer run Enable complex DOM benchmarks execution in official speedometer run Jul 12, 2023
@issackjohn issackjohn force-pushed the issackjohn/EnableTestSuitesForComplexDOMVersions branch 2 times, most recently from 149260c to 9a40ecb Compare July 13, 2023 18:37
@issackjohn issackjohn force-pushed the issackjohn/EnableTestSuitesForComplexDOMVersions branch from 9a40ecb to 68f74a2 Compare September 8, 2023 17:56
@issackjohn issackjohn force-pushed the issackjohn/EnableTestSuitesForComplexDOMVersions branch from 54470fd to e318f41 Compare September 29, 2023 19:11
@rniwa
Copy link
Member

rniwa commented Nov 14, 2023

Could you rebase and squash all the commits?

@issackjohn issackjohn force-pushed the issackjohn/EnableTestSuitesForComplexDOMVersions branch from 22c41f9 to 0486357 Compare November 21, 2023 19:21
@issackjohn
Copy link
Contributor Author

Could you rebase and squash all the commits?

Done

@issackjohn issackjohn force-pushed the issackjohn/EnableTestSuitesForComplexDOMVersions branch from 0486357 to a2685da Compare November 21, 2023 19:28
@rniwa
Copy link
Member

rniwa commented Dec 12, 2023

Thanks. We'd like to see #335 resolved before merging this PR.

@bgrins
Copy link
Contributor

bgrins commented Dec 15, 2023

Here's a commit that switches to the new list of tests mozilla@bb19795

@issackjohn
Copy link
Contributor Author

Here's a commit that switches to the new list of tests mozilla@bb19795

Thank you, I plan to make the same change.

@issackjohn
Copy link
Contributor Author

Here's a commit that switches to the new list of tests mozilla@bb19795

I did notice that TodoMVC-React was not disabled in the commit you linked, and I have disabled it in this PR as every TodoMVC test would execute either in the complex or stand-alone setting.

@issackjohn issackjohn force-pushed the issackjohn/EnableTestSuitesForComplexDOMVersions branch from 1a2db4e to b6d1a1b Compare December 19, 2023 17:03
Copy link
Contributor

@bgrins bgrins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Matches the test set we decided on, and should be landable alongside the upcoming isolation variant

@sulekhark
Copy link
Contributor

Thank you all for your support with the Complex DOM workload!

@issackjohn issackjohn merged commit 4173e4d into WebKit:main Dec 21, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
major change A change with major implications on benchmark results or affect governance policy v3-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants