-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable complex DOM benchmarks execution in official speedometer run #271
Enable complex DOM benchmarks execution in official speedometer run #271
Conversation
Added major change label: #264 (comment) |
81ee6b3
to
98e117b
Compare
149260c
to
9a40ecb
Compare
9a40ecb
to
68f74a2
Compare
54470fd
to
e318f41
Compare
Could you rebase and squash all the commits? |
22c41f9
to
0486357
Compare
Done |
0486357
to
a2685da
Compare
Thanks. We'd like to see #335 resolved before merging this PR. |
Here's a commit that switches to the new list of tests mozilla@bb19795 |
Thank you, I plan to make the same change. |
I did notice that TodoMVC-React was not disabled in the commit you linked, and I have disabled it in this PR as every TodoMVC test would execute either in the complex or stand-alone setting. |
1a2db4e
to
b6d1a1b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Matches the test set we decided on, and should be landable alongside the upcoming isolation variant
Thank you all for your support with the Complex DOM workload! |
Selected TodoMVC tests for complex setting
Selected TodoMVC tests for the stand-alone setting
Hosted version: https://issackjohn.github.io/SpeedometerWithComplex/#home