This repository has been archived by the owner on Dec 17, 2018. It is now read-only.
Modified get_meta_box_url() to return a protocol agnostic uri #639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HTTPS environments fail to load the asset on certain browsers due to http:// being a part of the uri. By being protocol agnostic, we play well with all environments.
|
I like this. However, can you please keep with the contribution guidelines, namely submit PR's against the trunk branch, and follow WP (and CMB) coding standards? Thank you kindly. |
|
Awesome, I'd be happy to - will just have to read up on those guidelines. Will have more time over the weekend. Yay for my first PR! |
|
thanks @Blindmikey! Now you're unstoppable. ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTTPS environments fail to load the asset on certain browsers due to http:// being a part of the uri. By being protocol agnostic, we play well with all environments.