Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libwabt.js #2520

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update libwabt.js #2520

wants to merge 1 commit into from

Conversation

dy
Copy link

@dy dy commented Dec 7, 2024

Rebuild from latest source.

Steps taken:

  1. Install deps
brew install binaryen cmake ninja
  1. Install & enable emsdk
git clone https://github.com/emscripten-core/emsdk.git
cd emsdk
./emsdk install latest
./emsdk activate latest
source ./emsdk_env.sh

(I could not figure out how to do that via brew)

  1. Build via makefile
make emscripten-release
cp out/emscripten/Release/libwabt.js docs/demo

or just

make demo

Copy link
Member

@sbc100 sbc100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mention in the description the precise steps you used to rebuild? I assume these are documented somewhere? I wonder if we should automate this?

@dy
Copy link
Author

dy commented Dec 8, 2024

@sbc100 added steps taken. I didn't find the docs, I had to hold conversation/experimentation with copilot to find out a way.
I found new libwabt versions fail parsing certain (if) constructs from official testsuite, compared to the one currently in demo. So automation would make demo somewhat unstable, same time would help detecting if something broke.

@SoniEx2
Copy link
Contributor

SoniEx2 commented Dec 8, 2024

(there are no docs. we wonder how it was done last time?)

@dy
Copy link
Author

dy commented Dec 8, 2024

@SoniEx2 just make demo. Providing you have all deps installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants