DynamicLinking.md: add notes about memory/table exports #234
Conversation
|
|
||
| On the other hand, non-PIE executables need to export these instance | ||
| resources as usual. | ||
|
|
||
| ## Implementation Status |
There was a problem hiding this comment.
I wonder if we can/should add something under this header for wasi now?
There was a problem hiding this comment.
do you mean to update the implementation status section?
There was a problem hiding this comment.
Yes, we mention LLVM here and emscripten, perhaps you could mention wasi-sdk too? i.e. what is the status there?
DynamicLinking.md
Outdated
| export them as well. For that reason, for PIE executables, we don't | ||
| require these resources exported. | ||
|
|
||
| Shared libraries don't need to export these instance resoures either |
There was a problem hiding this comment.
"Shared libraries should also import these resources, since they share a memory and function table with the main module."
|
@sbc100 It looks like you approved this; is this ready to land? |
DynamicLinking.md
Outdated
| require these resources exported. | ||
|
|
||
| Shared libraries don't need to export these resources either. | ||
| They should also import these resources, since they share the memory |
This is my attempt to capture the discussion in WebAssembly#232
yamt
force-pushed
the
dynamic-linking-import
branch
2 times, most recently
from
c155913 to
faf6c9e
Compare
yamt
force-pushed
the
dynamic-linking-import
branch
from
faf6c9e to
96fc30b
Compare
DynamicLinking.md
Outdated
|
|
||
| ``` | ||
| -fPIC \ | ||
| -Xlinker -pie \ |
There was a problem hiding this comment.
I believe -pie is clang flag. No need to -Xlinker here.
DynamicLinking.md
Outdated
| -fPIC \ | ||
| -shared \ | ||
| -Xlinker --experimental-pic \ | ||
| -Wl,--unresolved-symbols=import-dynamic |
There was a problem hiding this comment.
You can combine these two lines, or at least be consistent. -Xlinker and -Wl basically do the same things but -Wl allows you to specify more than one argument at time. e.g.:
-Wl,--experimental-pic,--unresolved-symbols=import-dynamic
There was a problem hiding this comment.
I think -Wl, is the more widely used/recognized one, but I could be wrong.
There was a problem hiding this comment.
Are you sure we want --unresolved-symbols=import-dynamic here? I would hope that the default of requiring all symbols to be resolved would work in many cases.
Perhaps its best to just drop this section listing specific link options since there are many combinations that can work, and since this is all experimental it could becoming out of date.
There was a problem hiding this comment.
Are you sure we want
--unresolved-symbols=import-dynamichere? I would hope that the default of requiring all symbols to be resolved would work in many cases.
i copy-and-pasted these options from my test scripts.
maybe it can be outdated and/or redundant.
Perhaps its best to just drop this section listing specific link options since there are many combinations that can work, and since this is all experimental it could becoming out of date.
ok. it makes sense. i will remove them.
DynamicLinking.md
Outdated
| -Xlinker --export=__stack_pointer \ | ||
| -Xlinker --export=__heap_base \ | ||
| -Xlinker --export=__heap_end \ | ||
| -z stack-size=16384 |
There was a problem hiding this comment.
No need to stack-size here right?
This is my attempt to capture the discussion in
#232