Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Oxford Dictionaries API Functionality #211

Merged
merged 6 commits into from
Mar 5, 2024
Merged

Remove Oxford Dictionaries API Functionality #211

merged 6 commits into from
Mar 5, 2024

Conversation

WayneLambert
Copy link
Owner

Addresses the following:

  • Removes Oxford API functionality from the app since Oxford Dictionaries essentially eliminated their hobby tier and made it so their lowest tier involves a £600 per annum "setup fee".
  • Removes any test functionality relating to the usage of the API
  • Removes any templating relating to word definitions, etc
  • Addresses linting issues reported by Ruff

@WayneLambert WayneLambert added dependencies Pull requests that update a dependency file app: countdown_letters Issues relating to the `countdown_letters` app refactor candidate Items that could be refactored at a later stage labels Mar 5, 2024
@WayneLambert WayneLambert self-assigned this Mar 5, 2024
@WayneLambert WayneLambert merged commit be64066 into main Mar 5, 2024
0 of 2 checks passed
sourcery-ai[bot]
sourcery-ai bot reviewed Mar 5, 2024
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey WayneLambert - Here's my review!

General suggestions:

  • Ensure that the removal of the Oxford API and its related functionality does not leave the application without a reliable word validation mechanism.
  • Consider adding alternative tests to cover the logic previously validated through the API responses.
  • Clarify how the removal of word definitions and classes from the game's results affects the user experience or the game's educational value.
  • Ensure that any new or modified functionality replacing the Oxford API is adequately tested.

Thanks for using Sourcery. We offer it for free for open source projects and would be very grateful if you could help us grow. If you like it, would you consider sharing Sourcery on your favourite social media? ✨

Share Sourcery

Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

apps/countdown_letters/tests/test_logic.py Show resolved Hide resolved
apps/countdown_letters/views.py Show resolved Hide resolved
apps/countdown_letters/utils.py Show resolved Hide resolved
apps/countdown_letters/tests/test_views.py Show resolved Hide resolved
.github/workflows/test.yml Show resolved Hide resolved
apps/users/views.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

Assignees

@WayneLambert WayneLambert

Labels
app: countdown_letters Issues relating to the `countdown_letters` app dependencies Pull requests that update a dependency file refactor candidate Items that could be refactored at a later stage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@WayneLambert