Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue updates #192

Merged
merged 7 commits into from
Oct 8, 2024
Merged

Vue updates #192

merged 7 commits into from
Oct 8, 2024

Conversation

RoelN
Copy link
Contributor

@RoelN RoelN commented Oct 8, 2024

No description provided.

@RoelN RoelN marked this pull request as ready for review October 8, 2024 14:44
@RoelN
Copy link
Contributor Author

RoelN commented Oct 8, 2024

It looks like I can drop a font, and then get past the Vue errors with this PR.

This is not to say that everything is fixed, it just means the site is now choking on something in the engine 🤣

@Ryuno-Ki or @mxdvl, if interested, would you want to do a review?

Copy link

@danieldiekmeier danieldiekmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just trying to set this project up and got all kinds of Vue errors. Then I saw this PR and it does indeed at least get the initial page to a working condition!

I still get some warning in App.vue that showModal and toggleModal are not defined. (And the toggling of the modal really does not work.) This can be fixed by using the new names introduced back here: ff8dc91

I can't comment directly on the App.vue as it's not part of this PR yet, but these are the changes that worked for me:

                @drop.prevent="getFont"
                @dragover.prevent="dragStatus(true)"
                @mouseout="dragStatus(false)"
-               @keydown.esc="toggleModal(true)"
+               @keydown.esc="toggleInfoModal(true)"
                tabindex="0"
                :class="{ dragging, working }"
        >
                <TheFondue
                        @getFont="getFont"
                        @getExampleFont="getExampleFont"
-                       @toggleModal="toggleModal"
+                       @toggleModal="toggleInfoModal"
                        :error="error"
                />
                <FontReport :font="font" :isExamplefont="isExamplefont" />
-               <InfoModal v-if="showModal" @toggleModal="toggleModal" />
+               <InfoModal v-if="showInfoModal" @toggleModal="toggleInfoModal" />
                <div class="beta-message">

Copy link
Contributor

@mxdvl mxdvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, my Vue knowledge is limited so I would not feel confident weighing in.

@RoelN
Copy link
Contributor Author

RoelN commented Oct 8, 2024

@danieldiekmeier Thanks! Yeah, I have all those warnings on my list for tomorrow. I missed that toggleModal stuff in the previous update — thanks for catching it!

@RoelN
Copy link
Contributor Author

RoelN commented Oct 8, 2024

I'll merge this now so it's easier to work from, if anyone wants to branch off and dive it!

@RoelN RoelN merged commit dcee2e6 into master Oct 8, 2024
1 check passed
@RoelN RoelN deleted the vue-updates branch October 8, 2024 16:10
@RoelN RoelN mentioned this pull request Oct 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants