-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue updates #192
Vue updates #192
Conversation
As per Vue 2 -> Vue 3 upgrade recommendation
And figure out later how to restore it, if we still want it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just trying to set this project up and got all kinds of Vue errors. Then I saw this PR and it does indeed at least get the initial page to a working condition!
I still get some warning in App.vue
that showModal
and toggleModal
are not defined. (And the toggling of the modal really does not work.) This can be fixed by using the new names introduced back here: ff8dc91
I can't comment directly on the App.vue
as it's not part of this PR yet, but these are the changes that worked for me:
@drop.prevent="getFont"
@dragover.prevent="dragStatus(true)"
@mouseout="dragStatus(false)"
- @keydown.esc="toggleModal(true)"
+ @keydown.esc="toggleInfoModal(true)"
tabindex="0"
:class="{ dragging, working }"
>
<TheFondue
@getFont="getFont"
@getExampleFont="getExampleFont"
- @toggleModal="toggleModal"
+ @toggleModal="toggleInfoModal"
:error="error"
/>
<FontReport :font="font" :isExamplefont="isExamplefont" />
- <InfoModal v-if="showModal" @toggleModal="toggleModal" />
+ <InfoModal v-if="showInfoModal" @toggleModal="toggleInfoModal" />
<div class="beta-message">
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, my Vue knowledge is limited so I would not feel confident weighing in.
@danieldiekmeier Thanks! Yeah, I have all those warnings on my list for tomorrow. I missed that |
I'll merge this now so it's easier to work from, if anyone wants to branch off and dive it! |
No description provided.