Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable running checks locally #190

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Enable running checks locally #190

merged 1 commit into from
Oct 8, 2024

Conversation

mxdvl
Copy link
Contributor

@mxdvl mxdvl commented Oct 8, 2024

Why?

So that all the CI steps can be consistently reproducible locally.

What?

Add a lint:check script that does what we had in CI.

Ryuno-Ki
Ryuno-Ki approved these changes Oct 8, 2024
View reviewed changes
Copy link
Contributor

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RoelN
Copy link
Contributor

RoelN commented Oct 8, 2024

Thanks @mxdvl 🙏

@RoelN RoelN merged commit 06be523 into Wakamai-Fondue:master Oct 8, 2024
1 check passed
@mxdvl mxdvl deleted the mxdvl/consistent-lint-check branch October 8, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryuno-Ki Ryuno-Ki Ryuno-Ki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mxdvl @RoelN @Ryuno-Ki