-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support anyio
, sending denial response, handshake headers
#34
base: main
Are you sure you want to change the base?
Conversation
And simplify the `UvicornServer` class in test
…he HTTP version restriction
… handling of closure BREAKING CHANGE: The return signature of `ReverseWebSocketProxy.proxy` has been changed; it no longer returns `StarletteResponse`, but instead returns `True`
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 96.74% 96.39% -0.35%
==========================================
Files 9 9
Lines 461 472 +11
Branches 67 73 +6
==========================================
+ Hits 446 455 +9
- Misses 9 11 +2
Partials 6 6 ☔ View full report in Codecov by Sentry. |
The test succeeded on Windows but failed on Linux, preventing us from merging. Unfortunately, I don't have time to address this issue at the moment. If someone is willing to pick it up, I can provide guidance. Need Improvement
TODO
|
I am aware of such downstream use cases, so we cannot deprecate the |
Summary
Added
Changed
ReverseWebSocketProxy.proxy
has been changed;it no longer returns
StarletteResponse
, but instead returnsTrue
Test
httpx
Checklist
CONTRIBUTING.md
.