2.11.3 #1145
Merged
2.11.3 #1145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristeacosmin
approved these changes
Nov 21, 2024
cristeacosmin
requested changes
Nov 21, 2024
| }); | ||
| if (idCheck != id || undefined == settings) { |
| success: (result) => onGalleryLoaded(id, result), | ||
| }); | ||
| setAttributes({ id: id, images: res.modulaImages }); | ||
| if (idCheck != id || undefined == settings) { |
| add_action( 'wp_ajax_modula_get_gallery', array( $this, 'get_gallery' ) ); | ||
| add_action( 'wp_ajax_modula_get_jsconfig', array( $this, 'get_jsconfig' ) ); | ||
| add_action( 'wp_ajax_modula_check_hover_effect', array( $this, 'check_hover_effect' ) ); | ||
| // Filter the gallery data for the REST API. Used for the Gutenberg editor, to remove the | ||
| // image data-width and data-height attributes. | ||
| add_filter( 'rest_prepare_modula-gallery', array( $this, 'rest_api_filter_data' ), 15, 3 ); |
There was a problem hiding this comment.
vezi ca ai callbackul pentru fieldul respectiv, de ce ai nevoie sa modifici tot raspunsul?
includes/class-modula-gutenberg.php
Outdated
| $data = $response->get_data(); | ||
| $modula_settings = $data['modulaSettings']; | ||
| if ( 'slider' !== $modula_settings['type'] ) { | ||
| return $response; |
There was a problem hiding this comment.
doar daca e slider e nevoie de functionalitatea asta? daca e o galerie care are un video - tot are nevoie de thumb
There was a problem hiding this comment.
🤦🏼 am copiat de la slider, partea aia trebuie sa o scot
cristeacosmin
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.